Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate Ninja projects here #1110

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

chore: migrate Ninja projects here #1110

wants to merge 36 commits into from

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented Mar 18, 2025

No description provided.

sesi200 and others added 2 commits March 18, 2025 15:43
@sesi200
...again
cc8cd66
@sesi200 @fxgst
Update motoko/hello_world/backend/app.mo
a6c0549 
Co-authored-by: Elias Datler <46360620+fxgst@users.noreply.github.com>
@jessiemongeon1 jessiemongeon1 marked this pull request as ready for review March 18, 2025 15:48
@jessiemongeon1 jessiemongeon1 requested review from a team as code owners March 18, 2025 15:48
@jessiemongeon1 jessiemongeon1 marked this pull request as draft March 18, 2025 15:48
@sesi200 sesi200 marked this pull request as ready for review March 21, 2025 09:04
fxgst
fxgst reviewed Mar 21, 2025
View reviewed changes
Copy link

@fxgst fxgst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a similar workflow like in the ninja repo such that we dont need to create a new workflow file for each project?

@sesi200 sesi200 marked this pull request as draft March 21, 2025 12:27
fxgst
fxgst approved these changes Mar 21, 2025
View reviewed changes
Copy link

@fxgst fxgst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sesi200 sesi200 marked this pull request as ready for review March 21, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxgst fxgst fxgst approved these changes

@jessiemongeon1 jessiemongeon1 jessiemongeon1 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sesi200 @fxgst @jessiemongeon1