Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump playwright #604

Merged
merged 2 commits into from
Mar 24, 2025
Merged

build: bump playwright #604

merged 2 commits into from
Mar 24, 2025

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Mar 17, 2025

Motivation

In Svelte v5 branch, Playwright is reporting a false/positive. Bumping the version resolve the issue.

Changes

  • Bump latest Playwright

Reference

CI that reports a false/positive: https://github.com/dfinity/gix-components/actions/runs/13892771696/job/38867389502?pr=548

Screenshot of the expected/actual "issue" comparison - i.e. no pixel difference:

image

Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@peterpeterparker peterpeterparker merged commit 41cbcd7 into main Mar 24, 2025
11 checks passed
@peterpeterparker peterpeterparker deleted the build/bump-playwright branch March 24, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants