fix: avoid enabling "js" feature of getrandom for wasm32 target #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninegua
force-pushed
the
paulliu/avoid-getrandom-js-feature
branch
from
5fb96fd to
574ba4a
Compare
|
Also made a PR upstream dylanhart/ulid-rs#86 |
ninegua
force-pushed
the
paulliu/avoid-getrandom-js-feature
branch
from
574ba4a to
2892429
Compare
|
Now that the problem with But we have another problem (that didn't previously exist): quinn-proto and ring (whose versions were updated in the latest master) also force |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
The following command currently failed to compile the registry canister if running from the /ic/rs/registery/canister sub-directory: cargo build --profile canister-release --target wasm32-unknown-unknown --bin registry-canister The fix is to make sure the feature `getrandom/custom` is enabled. Note that the above command would succeed if running from the top-level directory, but would produce incorrect wasm binary. This is because cargo would bring in global dependencies that enable both `getrandom/custom` and `getrandom/js` features, and the latter will lead to wasm binaries having unwanted imports (See #3309 for more details). Since this problem does not affect bazel builds, this fix is only relevant to cargo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency "tower-request-id" will pull in crate "ulid", which enables the "js" feature of crate "getrandom" for wasm32 targets. This is at odds for our canister compilation using cargo because because cargo works at global level and both "js" and "custom" features would be enabled, and the result wasm file would have unresolved symbols like
__wbindgen_placeholder__.Note that this problem does not exist for bazel compilation, but still is worth fixing.
The fix is simply to require a more recent version of "ulid" that does not enable the "js" feature of "getrandom".