Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve error highlighting range for M0072 #4897

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: improve error highlighting range for M0072 #4897

wants to merge 2 commits into from

Conversation

rvanasa
Copy link
Contributor

@rvanasa rvanasa commented Feb 13, 2025 •
edited
Loading

Changes the field * does not exist in type error message to use the AST range of the field identifier rather than the parent expression.

Mostly relevant for the Motoko VS Code extension, Motoko Playground, and ICP Ninja.

@github-actions GitHub Actions
Copy link

Comparing from a3dd9f3 to 0411bee:
The produced WebAssembly code seems to be completely unchanged.

@crusso crusso self-requested a review February 14, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusso crusso crusso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvanasa @crusso