feat: send telemetry data to backend #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report week ("YYYY-WW")
Trigger send if filesize exceeds threshold
| use clap::Parser; | ||
| use url::Url; | ||
|
|
||
| const DEFAULT_URL: &str = "https://sdk.telemetry.dfinity.network"; |
There was a problem hiding this comment.
maybe this should come from ToolConfig, which would allow tests to override it.
There was a problem hiding this comment.
I think that would be helpful, but since we're not automatically testing this for now maybe you can just leave a hint in a comment?
There was a problem hiding this comment.
I would, but because that would dismiss your CR approval, I'll let these comments serve for now.
sesi200
approved these changes
Mar 20, 2025
| use clap::Parser; | ||
| use url::Url; | ||
|
|
||
| const DEFAULT_URL: &str = "https://sdk.telemetry.dfinity.network"; |
There was a problem hiding this comment.
I think that would be helpful, but since we're not automatically testing this for now maybe you can just leave a hint in a comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This draft PR contains two commits.
The first adds
dfx _send-telemetry, not meant to be called except by dfx itself, that sends collected telemetry data to a backend.The second adds a mechanism for deciding when to automatically call the above, with file locking to ensure correct operation even if many commands are executed at once.
Fixes https://dfinity.atlassian.net/browse/SDK-1980
How Has This Been Tested?
Tested locally using https://github.com/rikonor/clickhouse-playground/tree/ens/dfx-events as the backend.
Checklist: