Skip to content

Commit

Permalink
Avoid upgrading Dapp via proposal in all cases (issues/83)
Browse files Browse the repository at this point in the history
  • Loading branch information
aterga committed Dec 4, 2024
1 parent 5bb09c4 commit 24e8889
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions run_basic_scenario.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,15 @@ done
# Assert that the test canister is indeed registered.
[ "$(./get_sns_canisters.sh | ./bin/idl2json | jq -r '.dapps[0]')" == "$(./bin/dfx canister id test)" ] && echo "OK" || exit 1

# TODO[dfinity/sns-testing/issues/83]: Re-enable upgrading dapp canisters via SNS proposals.
#
# Upgrade test canister (I)
./upgrade_test_canister.sh Hello
./wait_for_last_sns_proposal.sh
./wait_for_canister_running.sh "$(./bin/dfx canister id test)"

# assert the new greeting text
[ "$(./bin/dfx canister call test greet "M")" == '("Hello, M!")' ] && echo "OK" || exit 1
# ./upgrade_test_canister.sh Hello
# ./wait_for_last_sns_proposal.sh
# ./wait_for_canister_running.sh "$(./bin/dfx canister id test)"
#
# # assert the new greeting text
# [ "$(./bin/dfx canister call test greet "M")" == '("Hello, M!")' ] && echo "OK" || exit 1

# Participate in SNS swap
./participate_sns_swap.sh
Expand Down

0 comments on commit 24e8889

Please sign in to comment.