perf: Replace BTreeMap with constant vector in MemoryManager #240
+28
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # canbench_results.yml
Since we can have maximum 255 values, we can store those cheaply in a Vec and save time during the lookup.
frankdavid
changed the title
|
|
I am not entirely sure about this change. It works well maybe now that we can only allocate new memories but what if we finally merge the change which allows to free a memory? Wouldn't that nullify the benefits of using a vector? EDIT: I'm talking about the open PR on freeing a memory where I'm expecting a |
If you think we'd need to delete elements from the middle of the vector, that's not the case. We'll never delete elements from the outer We can remove a memory by simply taking its contents, eg: If this is confusing to read, I could wrap the whole thing into a struct which would have a similar API like stdlib |
I see, yeah I was thinking we might need to remove in the middle of the vector but I get your point. In this case, I agree the change is beneficial. |
|
@frankdavid nice change, thank you. I approve this change, but can we please wait for the memory freeing to first be merged, we have a couple of stacked PRs, and I hope that can be done next week. And after that, I will put a stamp here. Does that sound fine? |
|
Sure, no problem. |
|
Hey @frankdavid just an update, I believe the work on the memory manager will take more time than initially assumed, so please go forward and merge this PR if you think it is ready. |
dragoljub-duric
previously approved these changes
Nov 18, 2024
# Conflicts: # canbench_results.yml # src/btreemap/node.rs # src/btreemap/node/v1.rs # src/btreemap/node/v2.rs
|
After merging recent changes from master, I no longer see significant performance improvements from this change, so I won't move forward with this PR for now. |
# Conflicts: # canbench_results.yml
|
After studying our code more, I realized that we didn't have any benchmarks that properly exercised the MemoryManager, that's why we didn't see any improvements. A few new benchmarks were added in #253 and now the effect of this PR is visible (see benchmarks with |
dragoljub-duric
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can have maximum 255 memories, we can store those cheaply in a
Vecand save time during the lookup.