Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added creditcardnumber.ps1 in generators. #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tovervlag
Copy link
Contributor

Hello,

I added a creditcardnumber generator. It this what you're looking for? Or you want it to be more advanced?

Thanks,
Tovervlag

@dfinke
Copy link
Owner

dfinke commented May 12, 2021

Thanks!

I was looking at maybe porting this https://github.com/joke2k/faker/blob/master/faker/providers/credit_card/__init__.py
Looks like maybe too much effort.

@Tovervlag
Copy link
Contributor Author

I have never worked with classes, so it might be worth for me to just give it a go. I'll go over it in the next few days and I'll let you know.

@dfinke
Copy link
Owner

dfinke commented May 12, 2021


No Rush

Doesn't need to be in classes for the PS code, unless you want to try. Would need to have unit tests written.

Check
https://github.com/dfinke/NameIT/tree/master/__tests__

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants