Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve std feature propagation. #74

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Improve std feature propagation. #74

merged 1 commit into from
Nov 7, 2024

Conversation

xStrom
Copy link
Collaborator

@xStrom xStrom commented Nov 7, 2024

  • std and libm don't necessarily require zeno, so only enable the matching feature when zeno is already depended on.
  • Enable std also for yazi when appropriate.

waywardmonkeys
waywardmonkeys approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to use ? are good and I should've done that. I hadn't enabled yazi/std since nothing needed it, but that's fine too either way.

@xStrom xStrom merged commit 3a109b3 into dfrg:main Nov 7, 2024
9 checks passed
@xStrom xStrom deleted the stdwire branch November 7, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xStrom @waywardmonkeys