Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for no_std environments #1

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Add support for no_std environments #1

merged 1 commit into from
Sep 12, 2023

Conversation

notgull
Copy link
Contributor

@notgull notgull commented Sep 5, 2023

This commit adds a default "std" feature that can be disabled to run this crate in no_std environments. This allows for Zlib compression or decompression to happen on embedded systems.

Rel: dfrg/swash#4

This is a breaking change, as anyone who is already importing yazi with "default-features = false" and using the Fromio::Error impl on yazi::Error will have their build break after this commit.

This commit adds a default "std" feature that can be disabled to run
this crate in no_std environments. This allows for Zlib compression or
decompression to happen on embedded systems.

Rel: dfrg/swash#4

This is a breaking change, as anyone who is already importing yazi with
"default-features = false" and using the From<io::Error> impl on
yazi::Error will have their build break after this commit.

Signed-off-by: John Nunley <[email protected]>
Copy link
Owner

@dfrg dfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve been meaning to do this for a while, so thank you! The changes look good to me.

As noted, this is a breaking change so I’ll bump the version before release.

@dfrg dfrg merged commit 81f0323 into dfrg:master Sep 12, 2023
@notgull notgull deleted the no_std branch September 12, 2023 12:44
@notgull
Copy link
Contributor Author

notgull commented Nov 23, 2023

@dfrg Can you publish this?

@dfrg
Copy link
Owner

dfrg commented Nov 27, 2023

Yes, I can do this later today.

@dfrg
Copy link
Owner

dfrg commented Nov 29, 2023

published 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants