feat: add error message when data not found #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcannon068nw
approved these changes
Dec 4, 2023
jsstevenson
approved these changes
Dec 4, 2023
jsstevenson
approved these changes
Dec 4, 2023
jsstevenson
reviewed
Dec 7, 2023
katiestahl
added a commit
that referenced
this pull request
Dec 8, 2023
* feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: add 404 error page to drugs, genes, and interactions that have no data (#456) * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: add error message when data not found and fixing footer position * feat: add error message when data not found * style: removing console log * cleaning up code * refactor: extracting variable for interaction * feat: add 404 error page to drugs, genes, and interactions that have no data
Merged
katiestahl
added a commit
that referenced
this pull request
Dec 8, 2023
* Dev (#457) * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: add 404 error page to drugs, genes, and interactions that have no data (#456) * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: add error message when data not found and fixing footer position * feat: add error message when data not found * style: removing console log * cleaning up code * refactor: extracting variable for interaction * feat: add 404 error page to drugs, genes, and interactions that have no data * Automated frontend build * Automated frontend build --------- Co-authored-by: katiestahl <[email protected]>
mcannon068nw
added a commit
that referenced
this pull request
Dec 13, 2023
* feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: add 404 error page to drugs, genes, and interactions that have no data (#456) * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: add error message when data not found and fixing footer position * feat: add error message when data not found * style: removing console log * cleaning up code * refactor: extracting variable for interaction * feat: add 404 error page to drugs, genes, and interactions that have no data * add public/data as shared, linked dir * Update dgidb:load_local method (#463) * update file download location for dgidb_v5_latest in load_local methods * update download instructions with rake dgidb:load_local method * removed psql command in favor of just dgidb:load_local * fix spacing issue * prettier * add December 2023 download links --------- Co-authored-by: Katie Stahl <[email protected]> Co-authored-by: Adam Coffman <[email protected]>
mcannon068nw
added a commit
that referenced
this pull request
Dec 13, 2023
* Dev (#457) * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: add 404 error page to drugs, genes, and interactions that have no data (#456) * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: add error message when data not found and fixing footer position * feat: add error message when data not found * style: removing console log * cleaning up code * refactor: extracting variable for interaction * feat: add 404 error page to drugs, genes, and interactions that have no data * Automated frontend build * Automated frontend build * Dev (#464) * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: add 404 error page to drugs, genes, and interactions that have no data (#456) * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: update API page to show users endpoint for graphql requests * feat: add error message when data not found and fixing footer position * feat: add error message when data not found * style: removing console log * cleaning up code * refactor: extracting variable for interaction * feat: add 404 error page to drugs, genes, and interactions that have no data * add public/data as shared, linked dir * Update dgidb:load_local method (#463) * update file download location for dgidb_v5_latest in load_local methods * update download instructions with rake dgidb:load_local method * removed psql command in favor of just dgidb:load_local * fix spacing issue * prettier * add December 2023 download links --------- Co-authored-by: Katie Stahl <[email protected]> Co-authored-by: Adam Coffman <[email protected]> * Automated frontend build * Automated frontend build --------- Co-authored-by: Katie Stahl <[email protected]> Co-authored-by: katiestahl <[email protected]> Co-authored-by: Adam Coffman <[email protected]> Co-authored-by: mcannon068nw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should look into producing some sort of nice 404 error page with fancy dgidb branding and graphics down the road to make the app appeal more cohesive.
but for now, this PR makes an error message appear instead of a weirdly populated page with a bunch of "no data found" messages
this also fixes the footer hanging out randomly in the middle of some pages where the content doesn't take up the whole page. It will always be pushed to the bottom
close #451