Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in controlled mode to ignore any id that not in data #207

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yhy-1
Copy link
Collaborator

@yhy-1 yhy-1 commented Jan 15, 2025

To follow other tree view component patterns, we should ignore controlled selected and expanded id when they do not exist in the data as they can be removed. Only expand and select id that exist in data. If we don't it will errors since we expected to find it in the data when we render.

Use solution in #174 but also included selected id.

@yhy-1 yhy-1 changed the title UIEN-5599: Fix in controlled mode to ignore any id that not in data Fix in controlled mode to ignore any id that not in data Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant