Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification delay with doorbell_graham_cracker #1280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix notification delay with doorbell_graham_cracker #1280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/homebridge-ring/camera.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,19 @@ export class Camera extends BaseDataAccessory<RingCamera> {
) {
let imageUuid = this.device.latestNotificationSnapshotUuid

/**
* The low cost wired doorbell is effectively a battery camera and
* cannot fetch a new snapshot while recording is in progress
* See: https://github.com/dgreif/ring/issues/933
*/
if (this.device.deviceType === 'doorbell_graham_cracker' && !imageUuid) {
logInfo(
this.device.name +
` ${eventDescription}. Bypassing snapshot load before sending event to HomeKit`
)
return characteristicValue
}

/**
* Battery cameras may receive an initial notification with no image uuid,
* followed shortly by a second notification with the image uuid. We need to
Expand Down