Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg: Expose stdout callback to user #1386

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

kkuehlz
Copy link
Contributor

@kkuehlz kkuehlz commented Jan 9, 2024

Integrating in homebridge/camera-utils#584

Would appreciate if we could do a new release once this is merged so I can use in my application.

@kkuehlz
Copy link
Contributor Author

kkuehlz commented Jan 9, 2024

cc @dgreif

Don't have permission to request reviewers

@dgreif
Copy link
Owner

dgreif commented Jan 10, 2024

@keur I'll go ahead and merge this, but I'm not sure we need to do a release just for this bump. Since we allow patch/minor updates for the @homebridge/camera-utils package, you should be able to install the latest version of that package and have ring automatically start using it.

@dgreif dgreif merged commit ea11e78 into dgreif:main Jan 10, 2024
2 checks passed
@kkuehlz
Copy link
Contributor Author

kkuehlz commented Jan 10, 2024

@dgreif Thank you!

The way I call startTranscoding() has changed with this new callback option. I understand if you don't want to do a release for such a tiny API change. I'm fine pointing the package at git+https://github/dgreif/ring#main. In fact, I am doing that right now to point at my fork. However, I am including it from a JS project. That means I need to go into node_modules and manually build the ring-client-api package, then include the lib directory. My final include ends up looking like this: const { RingApi } = require('ring/packages/ring-client-api/lib')

It gets a little ugly. Is there a better way to do that? I don't program JS regularly, so apologies if these are basic questions.

EDIT: Nevermind. I just published the package to npm under my own username. So I have a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants