Edit Timesheet Pageload Performance #298
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed a performance issue when loading the edit timesheet page, the request can become blocking if multiple users load the page simultaneously. It is more obvious when impersonating an admin account on a Redmine instance with lots of projects and users (see #242 for more details) . The slowdown comes from the project list being iterated in Ruby, then each members of each projects being added to a list then deduped.
The solution is to make a single SQL query to get the users by filtering them by their projects (listed in the members table). That doesn't require looping through a large list and it has proven to be much more efficient. From the benchmark I've run on my production environment, pageload went from 4000~6000ms to 500~800ms, the SQL query being < 10ms.