fix: true-only checkbox lastSynced comparison

dhis2 · Sep 25, 2022 · f15bbfb · f15bbfb
1 parent d36c226
commit f15bbfb
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/data-workspace/inputs/true-only-checkbox.js b/src/data-workspace/inputs/true-only-checkbox.js
@@ -32,7 +32,9 @@ export const TrueOnlyCheckbox = ({
             {
                 onSuccess: () => {
                     form.mutators.setFieldData(fieldname, {
-                        lastSyncedValue: value,
+                        // value will be formatted to boolean, so keep same format
+                        // '' becomes false
+                        lastSyncedValue: !!value,
                     })
                 },
             }
@@ -43,7 +45,9 @@ export const TrueOnlyCheckbox = ({
     const handleBlur = () => {
         // For 'True only', can only send 'true' (or '1') or ''
         const value = input.checked ? 'true' : ''
-        if (valid && value !== data.lastSyncedValue) {
+        const lastVal = data.lastSyncedValue ? 'true' : ''
+
+        if (valid && value !== lastVal) {
             syncData(value)
         }
     }