Skip to content

Commit

Permalink
fix: default visualizationHasTimeDimension to true
Browse files Browse the repository at this point in the history
Without this default value the changes in this PR would actually
constitute to a breaking change, at least for the line-listing-app:
if the `visualizationHasTimeDimension` prop is not provided and the
`type` equals `eventVisualization`, the helptext would be rendered.
By defaulting to `true` we avoid this, only explicitly setting
`visualizationHasTimeDimension` to `false` will cause the help text to
show.

I think this is mainly a theoretical issue, because the line-listing-app
will always set the prop. But who knows: there could be a 3rd party app
out there using the analytics library which would break because of this.
  • Loading branch information
HendrikThePendric committed Sep 13, 2023
1 parent 9ab5d50 commit 8493077
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ InterpretationsUnit.displayName = 'InterpretationsUnit'

InterpretationsUnit.defaultProps = {
onInterpretationClick: Function.prototype,
visualizationHasTimeDimension: true,
}

InterpretationsUnit.propTypes = {
Expand Down

0 comments on commit 8493077

Please sign in to comment.