fix: use translated dimension labels in PT (DHIS2-15750) #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhenrikoverland
approved these changes
Sep 11, 2023
edoardo
force-pushed
the
fix/translate-dimension-labels-pt-DHIS2-15750
branch
from
3b70090 to
a341e57
Compare
dhis2-bot
added a commit
that referenced
this pull request
Sep 15, 2023
## [26.0.19](v26.0.18...v26.0.19) (2023-09-15) ### Bug Fixes * use translated dimension labels in PT DHIS2-15750 ([#1572](#1572)) ([492975e](492975e))
|
🎉 This PR is included in version 26.0.19 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janhenrikoverland
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DHIS2-15750
Relates to https://github.com/dhis2/data-visualizer-app/pull/XXX
Key features
Description
In Pivot Table visualizations it's possible to enable dimension labels via options.
These were not translated.
The PR fixes the issue by marking those strings for translation.
Screenshots
Before:
After:
