fix: export function for preparing payload for copy (DHIS2-15722) #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkrulltott
approved these changes
Sep 14, 2023
Merged
2 tasks
Better than relying on apps not fetching the user information when loading a visualization.
edoardo
force-pushed
the
fix/function-for-preparing-ao-for-copy-DHIS2-15722
branch
from
f62754b to
327ce6b
Compare
edoardo
deleted the
fix/function-for-preparing-ao-for-copy-DHIS2-15722
branch
dhis2-bot
added a commit
that referenced
this pull request
Sep 25, 2023
## [26.0.20](v26.0.19...v26.0.20) (2023-09-25) ### Bug Fixes * export function for preparing payload for copy DHIS2-15722 ([#1573](#1573)) ([a1f8d69](a1f8d69))
|
🎉 This PR is included in version 26.0.20 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janhenrikoverland
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for DHIS2-15722
Relates to dhis2/line-listing-app#433
Key features
Description
The bug described in the ticket applies to all analytics apps, all need to use the same fix.
Instead of duplicating the code in all apps, export a utility function from
analyticsthat can be used by all apps.