feat: single value as a Highcharts instance #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikThePendric
changed the title
HendrikThePendric
force-pushed
the
feat/single-value-as-highcharts-chart-DHIS2-17928
branch
from
c880c56 to
bbdd316
Compare
src/visualizations/config/adapters/dhis_highcharts/customSVGOptions/index.js
Outdated
Show resolved
Hide resolved
...ions/config/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/addIconElement.js
Outdated
Show resolved
Hide resolved
...lizations/config/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/constants.js
Outdated
Show resolved
Hide resolved
...ns/config/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/positionElements.js
Outdated
Show resolved
Hide resolved
src/visualizations/config/adapters/dhis_highcharts/customSVGOptions/index.js
Outdated
Show resolved
Hide resolved
...ions/config/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/addIconElement.js
Outdated
Show resolved
Hide resolved
...ns/config/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/positionElements.js
Outdated
Show resolved
Hide resolved
...onfig/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/renderSingleValueSVG.js
Outdated
Show resolved
Hide resolved
...sualizations/config/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/styles.js
Outdated
Show resolved
Hide resolved
src/visualizations/config/adapters/dhis_highcharts/subtitle/index.js
Outdated
Show resolved
Hide resolved
src/visualizations/config/adapters/dhis_highcharts/title/index.js
Outdated
Show resolved
Hide resolved
This was referenced Sep 24, 2024
...onfig/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/renderSingleValueSVG.js
Outdated
Show resolved
Hide resolved
6 tasks
edoardo
reviewed
Oct 17, 2024
...onfig/adapters/dhis_highcharts/customSVGOptions/singleValue/config/shouldUseContrastColor.js
Outdated
Show resolved
Hide resolved
...ions/config/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/addIconElement.js
Outdated
Show resolved
Hide resolved
edoardo
reviewed
Oct 17, 2024
…zation This fixes an issue in client-side PDF exports
…es and string values
HendrikThePendric
force-pushed
the
feat/single-value-as-highcharts-chart-DHIS2-17928
branch
from
159727c to
3065022
Compare
edoardo
approved these changes
Oct 22, 2024
* chore: remove old code * chore: adjust story and remove imports for deleted files
HendrikThePendric
deleted the
feat/single-value-as-highcharts-chart-DHIS2-17928
branch
dhis2-bot
added a commit
that referenced
this pull request
Oct 22, 2024
# [26.9.0](v26.8.8...v26.9.0) (2024-10-22) ### Features * implement Single Value as a Highcharts.Chart instance and add offline exporting module ([#1698](#1698)) ([40fdfba](40fdfba))
|
🎉 This PR is included in version 26.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-17928
Relates to https://dhis2.atlassian.net/browse/DHIS2-17722
Key features
Description
We want to deprecate the SVG to PNG/PDF endpoints and export visualisations in the browser instead. To do so we can leverage Highchart's
Chart.exportChartLocal()method. However, since the Single Value visualisation type was a completely custom implementation, not built in Highcharts, this visualisation type was problematic. We considered two approaches:We investigated both options and have summarised our findings in this document. The final decision was to refactor the Single Value as a Highcharts Chart, which is what has been done in the current PR.
Apart from the Single Value refactor, this PR introduces some mechanisms to implement future custom visualizations using Highcharts as well.
Note that while this PR adds 1692 lines, this includes a story of 823 lines and that the current state of affairs still includes the old implementation. Removing the old code would remove ~970 lines. So when everything is done we'll actually be reducing the codebase size by about 100 lines (1692-823-970=-101).
TODO / Discussion points
src/visualizations/config/adapters/dhis_dhissrc/visualizations/config/generators/dhissrc/visualizations/store/adapters/dhis_dhisNote that the last 4 points can easily be completed as follows:
chore/remove-old-single-value-codeonto this branch