-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DHIS2-13915): show spinner when an app is being installed #542
Conversation
🚀 Deployed on https://pr-542--dhis2-app-management.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this so I'm not blocking the PR in case my feedback won't be addressed until next week when I'm on vacation
753ce7b
to
09d201d
Compare
@tomzemp I encountered the error with dhis/prop-types - this was caused by this project requiring an older version that exposed all PropTypes from |
09d201d
to
d2649d8
Compare
d2649d8
to
f605167
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #542 +/- ##
==========================================
+ Coverage 13.03% 13.10% +0.06%
==========================================
Files 23 23
Lines 445 458 +13
Branches 122 129 +7
==========================================
+ Hits 58 60 +2
- Misses 340 350 +10
- Partials 47 48 +1 ☔ View full report in Codecov by Sentry. |
84edcd8
to
0cfa9a3
Compare
makes sense @kabaros. no issues running for me now 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 🚀
🎉 This PR is included in version 100.2.32 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes DHIS2-13915 and DHIS2-15586.
DHIS2-13915
This adds a spinner to the install button in the main app details and the version list
DHIS2-13915
This PR also fixes DHIS2-15586. This is a workaround in the absence of an ID we can rely on, it matches the app with the installed apps using the name + developer email. The chances of these conflicting are low, and I think this is better than the current situation where users can't tell at all if an app was installed or not (check video in Jira ticket).