Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DHIS2-13294): add link to navigate to app after install #555

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

kabaros
Copy link
Contributor

@kabaros kabaros commented Aug 29, 2024

part of the fix for DHIS2-13294 - depends on dhis2/dhis2-core#18454

Adds a link to navigate to the installed app on success.

app-install-go-link

@kabaros kabaros requested review from a team as code owners August 29, 2024 09:33
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Aug 29, 2024

🚀 Deployed on https://pr-555--dhis2-app-management.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify August 29, 2024 09:34 Inactive
@kabaros kabaros force-pushed the DHIS2-13294/go-to-installed-app branch from 5f3415b to 430e3ca Compare August 29, 2024 16:04
@kabaros kabaros requested a review from a team August 29, 2024 16:04
@dhis2-bot dhis2-bot temporarily deployed to netlify August 29, 2024 16:05 Inactive
Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@dhis2-bot dhis2-bot temporarily deployed to netlify September 10, 2024 07:30 Inactive
@kabaros
Copy link
Contributor Author

kabaros commented Sep 10, 2024

@cooper-joe is the UX for this ok with you? I labelled the button "Go to app" .. but it's actually "go to app page in app management" rather than going to the actual app. I can't think of a good way to distinguish the two (we'll be adding a link to go the actual app from the app details page)

@cooper-joe
Copy link
Member

cooper-joe commented Sep 10, 2024

@cooper-joe is the UX for this ok with you? I labelled the button "Go to app" .. but it's actually "go to app page in app management" rather than going to the actual app. I can't think of a good way to distinguish the two (we'll be adding a link to go the actual app from the app details page)

A label like "View app details" here is a bit less concise, but it is clearer where it is taking the user. In the future the link to the actual app on the app management page could have a label like "Open app".

@dhis2-bot dhis2-bot temporarily deployed to netlify September 10, 2024 14:15 Inactive
@kabaros kabaros force-pushed the DHIS2-13294/go-to-installed-app branch from a91aa36 to 3d6b6d7 Compare September 10, 2024 14:19
@kabaros kabaros enabled auto-merge (squash) September 10, 2024 14:19
@kabaros kabaros disabled auto-merge September 10, 2024 14:19
@kabaros kabaros enabled auto-merge (squash) September 10, 2024 14:20
@dhis2-bot dhis2-bot temporarily deployed to netlify September 10, 2024 14:20 Inactive
@kabaros kabaros removed request for a team September 11, 2024 06:18
auto-merge was automatically disabled September 11, 2024 06:19

Head branch was modified

@kabaros kabaros force-pushed the DHIS2-13294/go-to-installed-app branch from 3d6b6d7 to 65693c8 Compare September 11, 2024 06:19
@dhis2-bot dhis2-bot temporarily deployed to netlify September 11, 2024 06:20 Inactive
@kabaros kabaros merged commit 27e157a into master Sep 11, 2024
7 checks passed
@kabaros kabaros deleted the DHIS2-13294/go-to-installed-app branch September 11, 2024 06:27
dhis2-bot added a commit that referenced this pull request Sep 11, 2024
## [100.2.36](v100.2.35...v100.2.36) (2024-09-11)

### Bug Fixes

* **DHIS2-13294:** add link to navigate to app after install ([#555](#555)) ([27e157a](27e157a))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.2.36 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants