fix: add endpoint to text plain matchers (#1390)

dhis2 · Nov 19, 2024 · bc25458 · bc25458
1 parent 39186d3
commit bc25458
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/services/data/src/links/RestAPILink/queryToRequestOptions/textPlainMatchers.test.ts b/services/data/src/links/RestAPILink/queryToRequestOptions/textPlainMatchers.test.ts
@@ -258,4 +258,18 @@ describe('isExpressionDescriptionValidation', () => {
             })
         ).toBe(false)
     })
+    it('returns true for a POST to "programIndicators/expression/description"', () => {
+        expect(
+            isExpressionDescriptionValidation('create', {
+                resource: 'programIndicators/expression/description',
+            })
+        ).toBe(true)
+    })
+    it('retuns false for a POST to a different resource', () => {
+        expect(
+            isMetadataPackageInstallation('create', {
+                resource: 'programIndicators/expression/somethingelse',
+            })
+        ).toBe(false)
+    })
 })
diff --git a/services/data/src/links/RestAPILink/queryToRequestOptions/textPlainMatchers.ts b/services/data/src/links/RestAPILink/queryToRequestOptions/textPlainMatchers.ts
@@ -122,9 +122,11 @@ export const isMetadataPackageInstallation = (
     { resource }: ResolvedResourceQuery
 ): boolean => type === 'create' && resource === 'synchronization/metadataPull'
 
-// POST to 'indicaators/expression/description' (validate an expression)
+// POST to 'indicators/expression/description' or 'programIndicator/expression/description' (validate an expression)
 export const isExpressionDescriptionValidation = (
     type: FetchType,
     { resource }: ResolvedResourceQuery
-): boolean =>
-    type === 'create' && resource === 'indicators/expression/description'
+): boolean => {
+    const pattern = /^(indicators|programIndicators)\/expression\/description$/
+    return type === 'create' && pattern.test(resource)
+}