Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [TECH-1539] Use Capture-UI IconButton #3415

Merged
merged 10 commits into from
Oct 27, 2023
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ import DialogActions from '@material-ui/core/DialogActions';
import DialogContent from '@material-ui/core/DialogContent';
import DialogTitle from '@material-ui/core/DialogTitle';
import { withStyles } from '@material-ui/core/styles';
import IconButton from '@material-ui/core/IconButton';
import { IconButton } from 'capture-ui';
import { IconCross24, Button } from '@dhis2/ui';
import i18n from '@dhis2/d2-i18n';
import isDefined from 'd2-utilizr/lib/isDefined';

const styles = theme => ({
const styles = () => ({
closeButton: {
height: theme.spacing.unit * 4,
marginTop: '5px',
},
actionContainer: {
paddingRight: 2,
Expand Down Expand Up @@ -58,7 +58,7 @@ class Index extends React.Component<Props> {
const { feedback, classes } = this.props;

return (
<span>
<>
{
(() => {
if (!feedback.action) {
Expand All @@ -75,15 +75,12 @@ class Index extends React.Component<Props> {
})()
}
<IconButton
key="close"
aria-label="Close"
color="inherit"
className={classes.closeButton}
onClick={this.handleClose}
>
<IconCross24 />
</IconButton>
</span>
</>
);
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// @flow
import * as React from 'react';
import { IconButton } from '@material-ui/core';
import { IconButton } from 'capture-ui';
import { IconSettings24, Tooltip } from '@dhis2/ui';
import i18n from '@dhis2/d2-i18n';
import { ColumnSelectorDialog } from './ColumnSelectorDialog.component';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const getStyles = (theme: Theme) => ({
},
topBarButtonContainer: {
display: 'flex',
gap: '6px',
alignItems: 'center',
},
paginationContainer: {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
// @flow
import React, { useCallback, memo, type ComponentType } from 'react';
import { IconButton } from 'capture-ui';
import { withStyles } from '@material-ui/core/styles';
import { Divider, IconMore24 } from '@dhis2/ui';
import { IconButton, Paper, MenuList, MenuItem } from '@material-ui/core';
import { Paper, MenuList, MenuItem } from '@material-ui/core';

import { MenuPopper } from '../../Popper/Popper.component';
import type { Props } from './listViewMenu.types';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
*/
import * as React from 'react';
import { withStyles } from '@material-ui/core/styles';

import IconButton from '@material-ui/core/IconButton';
import { IconButton } from 'capture-ui';
import { IconChevronLeft24, IconChevronRight24 } from '@dhis2/ui';

const styles = (theme: Theme) => ({
root: {
flexShrink: 0,
display: 'flex',
color: theme.palette.text.secondary,
},
});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// @flow
import { IconChevronDown24, IconChevronUp24, colors } from '@dhis2/ui';
import { colors } from '@dhis2/ui';
import React, { Component } from 'react';
import { withStyles } from '@material-ui/core/styles';
import IconButton from '@material-ui/core/IconButton';
import { ChevronIcon } from 'capture-ui';

const styles = () => ({
container: {
Expand Down Expand Up @@ -85,14 +85,12 @@ class SectionHeaderSimplePlain extends Component<Props> {
(() => {
if (onChangeCollapseState) {
return (
<IconButton
data-test="collapsible-button"
<ChevronIcon
open={!this.props.isCollapsed}
onOpen={this.handleChangeCollapse}
onClose={this.handleChangeCollapse}
disabled={!this.props.isCollapseButtonEnabled}
title={this.props.isCollapsed ? 'Open' : 'Close'}
onClick={this.handleChangeCollapse}
>
{this.props.isCollapsed ? <IconChevronDown24 /> : <IconChevronUp24 />}
</IconButton>
/>
);
}
return null;
Expand Down
4 changes: 2 additions & 2 deletions src/core_modules/capture-ui/AgeField/AgeField.component.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import React, { Component } from 'react';
import { isValidPositiveInteger } from 'capture-core-utils/validators/form';
import i18n from '@dhis2/d2-i18n';
import classNames from 'classnames';
import IconButton from '@material-ui/core/IconButton';
import { IconButton } from 'capture-ui';
import { IconCross24 } from '@dhis2/ui';
import { AgeNumberInput } from '../internal/AgeInput/AgeNumberInput.component';
import { AgeDateInput } from '../internal/AgeInput/AgeDateInput.component';
Expand Down Expand Up @@ -249,7 +249,7 @@ class D2AgeFieldPlain extends Component<Props> {
{this.renderNumberInput(currentValues, 'months', 'Months')}
{this.renderNumberInput(currentValues, 'days', 'Days')}
<div className={ageClearClass}>
<IconButton style={{ width: 42, height: 42 }} disabled={!!disabled} onClick={this.onClear}>
<IconButton disabled={!!disabled} onClick={this.onClear}>
<IconCross24 />
</IconButton>

Expand Down
1 change: 1 addition & 0 deletions src/core_modules/capture-ui/AgeField/ageField.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
.containerHorizontal {
display: flex;
flex-wrap: wrap;
align-items: center;
}

.ageNumberInputContainer {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import i18n from '@dhis2/d2-i18n';
import { Map, TileLayer, Marker, withLeaflet } from 'react-leaflet';
import { ReactLeafletSearch } from 'react-leaflet-search-unpolyfilled';
import { IconCross24, Button } from '@dhis2/ui';
import IconButton from '@material-ui/core/IconButton';
import { IconButton } from 'capture-ui';
import { AddLocationIcon } from '../Icons';
import { CoordinateInput } from '../internal/CoordinateInput/CoordinateInput.component';
import defaultClasses from './coordinateField.module.css';
Expand Down Expand Up @@ -125,12 +125,10 @@ export class CoordinateField extends React.Component<Props, State> {
<IconButton
disabled={!!disabled}
style={{ height: 42, width: 42, borderRadius: 0, padding: 0 }}
classes={{ root: classNames(defaultClasses.mapIcon, mapIconCustomClass) }}
className={classNames(defaultClasses.mapIcon, mapIconCustomClass)}
onClick={this.openMap}
>
<AddLocationIcon
onClick={this.openMap}

/>
<AddLocationIcon />
</IconButton>

</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@
.mapIconContainerWithMargin {
position: relative;
display: flex;
overflow: hidden;
align-items: center;
justify-content: center;
height: 41px;
width: 41px;
height: 40.5px;
width: 40.5px;
border: 1px solid #a0adba;
border-radius: 4px 0px 0px 4px;
color: #212934;
Expand Down
42 changes: 38 additions & 4 deletions src/core_modules/capture-ui/IconButton/IconButton.component.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,36 @@
// @flow
import React, { useCallback } from 'react';
import cx from 'classnames';
import classes from './iconButton.module.css';
import { withStyles } from '@material-ui/core/styles';
import { colors } from '@dhis2/ui';
import type { Props } from './iconButton.types';

export const IconButton = ({ children, className, dataTest, onClick, ...passOnProps }: Props) => {
const styles = {
button: {
cursor: 'pointer',
borderRadius: '3px',
simonadomnisoru marked this conversation as resolved.
Show resolved Hide resolved
display: 'flex',
alignItems: 'center',
padding: '2px',
justifyContent: 'center',
color: colors.grey700,
'&:hover': {
background: colors.grey200,
color: colors.grey800,
},
'&:focus': {
outline: 'solid',
background: colors.grey200,
color: colors.grey800,
},
'&.disabled': {
color: colors.grey500,
cursor: 'not-allowed',
},
},
};

const IconButtonPlain = ({ children, className, dataTest, onClick, disabled, classes, ...passOnProps }: Props) => {
const handleKeyDown = useCallback((event: SyntheticKeyboardEvent<HTMLSpanElement>) => {
if ([' ', 'Enter', 'Spacebar'].includes(event.key)) {
onClick(event);
Expand All @@ -15,12 +41,18 @@ export const IconButton = ({ children, className, dataTest, onClick, ...passOnPr
event.preventDefault();
}, []);

const onClickHandler = useCallback((event: SyntheticMouseEvent<HTMLSpanElement>) => {
if (disabled) return null;
return onClick(event);
}, [disabled, onClick]);

return (
<span
{...passOnProps}
onClick={onClick}
onClick={onClickHandler}
disabled={disabled}
data-test={dataTest}
simonadomnisoru marked this conversation as resolved.
Show resolved Hide resolved
className={cx(classes.button, className)}
className={cx(classes.button, { disabled, ...(className ? { [className]: true } : {}) })}
type="button"
role="button"
tabIndex="0"
Expand All @@ -31,3 +63,5 @@ export const IconButton = ({ children, className, dataTest, onClick, ...passOnPr
</span>
);
};

export const IconButton = withStyles(styles)(IconButtonPlain);
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@
outline-width: 1px;
outline-offset: 0px;
}

2 changes: 2 additions & 0 deletions src/core_modules/capture-ui/IconButton/iconButton.types.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,7 @@ export type Props = {
children: React$Node,
className?: string,
dataTest?: string,
disabled?: boolean,
onClick: (event: SyntheticKeyboardEvent<HTMLSpanElement> | SyntheticMouseEvent<HTMLSpanElement> | SyntheticTouchEvent<HTMLSpanElement>) => void,
...CssClasses,
};
87 changes: 87 additions & 0 deletions src/core_modules/capture-ui/Icons/ChevronIcon.component.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
// @flow
import React, { useState, useEffect } from 'react';
import { IconButton } from 'capture-ui';
import cx from 'classnames';
import { withStyles } from '@material-ui/core/styles';
import { colors, spacersNum, IconChevronUp24 } from '@dhis2/ui';

type ChevronIconProps = {
open: boolean,
onOpen: () => void,
onClose: () => void,
disabled?: boolean,
...CssClasses,
};

const styles = {
toggleButton: {
margin: `0 0 0 ${spacersNum.dp4}px`,
height: '24px',
borderRadius: '3px',
color: colors.grey600,
'&:hover': {
background: colors.grey200,
color: colors.grey800,
},
'&.open': {
animation: 'flipOpen 200ms normal forwards linear',
},
'&.close': {
animation: 'flipClose 200ms normal forwards linear',
},
'&.closeinit': {
transform: 'rotateX(180deg)',
},
'&.disabled': {
color: colors.grey400,
cursor: 'not-allowed',
},
},
'@keyframes flipOpen': {
from: { transform: 'rotateX(180deg)' },
to: { transform: 'rotateX(0)' },
},
'@keyframes flipClose': {
from: { transform: 'rotateX(0)' },
to: { transform: 'rotateX(180deg)' },
},
};

const ChevronIconPlain = ({ open, onOpen, onClose, disabled, classes }: ChevronIconProps) => {
const [postEffectOpen, setPostEffectOpenStatus] = useState(open);
const [animationsReady, setAnimationsReadyStatus] = useState(false);

const handleClick = () => {
if (disabled) {
return null;
}
return open ? onClose : onOpen;
};

useEffect(() => {
if (!animationsReady) {
setAnimationsReadyStatus(true);
}

setPostEffectOpenStatus(open);
}, [open, animationsReady]);

return (
<IconButton
dataTest="widget-open-close-toggle-button"
className={cx(classes.toggleButton, {
closeinit: !animationsReady && !postEffectOpen,
open: animationsReady && postEffectOpen,
close: animationsReady && !postEffectOpen,
disabled,
})}
onClick={handleClick}
disabled={disabled}
>
<IconChevronUp24 />
</IconButton>
);
};

export const ChevronIcon = withStyles(styles)(ChevronIconPlain);

1 change: 1 addition & 0 deletions src/core_modules/capture-ui/Icons/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@ export { MultiSelectionUncheckedIcon } from './MultiSelectionUncheckedIcon.compo
export { SingleSelectionCheckedIcon } from './SingleSelectionCheckedIcon.component';
export { SingleSelectionUncheckedIcon } from './SingleSelectionUncheckedIcon.component';
export { BookmarkAddIcon } from './BookmarkAddIcon.component';
export { ChevronIcon } from './ChevronIcon.component';

1 change: 1 addition & 0 deletions src/core_modules/capture-ui/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,6 @@ export { Pagination } from './Pagination/Pagination.component';
// UI-Elements
export { DividerHorizontal } from './Divider/DividerHorizontal.component';
export { IconButton } from './IconButton';
export { ChevronIcon } from './Icons';
export { NonBundledIcon } from './NonBundledIcon';
export { FlatList } from './FlatList';
Loading