Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DHIS2-15187][DHIS2-15190] Working list bulk actions #3773

Merged
merged 42 commits into from
Nov 12, 2024
Merged

feat: [DHIS2-15187][DHIS2-15190] Working list bulk actions #3773

merged 42 commits into from
Nov 12, 2024

Conversation

eirikhaugstulen
Copy link
Contributor

@eirikhaugstulen eirikhaugstulen commented Aug 26, 2024 •
edited
Loading

Tech-summary:

  • Added a selection checkbox in the working list
  • Added a generic BulkActionsBar component

Event bulk actions:

  • Complete events
  • Delete events
  • Deselect

Tracked entity actions:

  • Complete enrollments
    • Does a dryRun to the api to look for errors
    • Partial update if any invalid data
    • Deselects partial imported enrollments if any
  • Delete enrollments
    • Able to delete active, completed and cancelled enrollments (user selects combination)
  • Deselect

Left to do:

  • Tests for tracked entity lists
  • Documentation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-3773.capture.netlify.dhis2.org

@eirikhaugstulen
chore: add tests for event working lists
f004ea8
@eirikhaugstulen
Merge remote-tracking branch 'refs/remotes/origin/master' into eh/fea…
744eeb2 
…t/DHIS2-15187-working-list-bulk-action

# Conflicts:
#	cypress/e2e/WorkingLists/EventWorkingLists/EventWorkingListsUser/EventWorkingListsUser.js
@eirikhaugstulen eirikhaugstulen marked this pull request as ready for review October 10, 2024 11:51
@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner October 10, 2024 11:51
@eirikhaugstulen eirikhaugstulen added e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud testing labels Oct 13, 2024
simonadomnisoru
simonadomnisoru reviewed Oct 28, 2024
View reviewed changes
...ingLists/TeiWorkingLists/TrackedEntityBulkActions/Actions/DeleteTeiAction/DeleteTeiAction.js

return (
<>
<Button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DeleteTeiaction action is missing the program access and trackedEntityType checks. Can something similar to how WidgetProfile currently works be implemented? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think you're right. However, I've only added it as a comment for what to implement in the future. This will not be part of the first iteration as there was some uncertainty wether this should be included at all 👍 (Also, I think the F_TEI_CASCADE_DELETE should override both program and TET access, so I'm not sure if it's needed. If not, we would have to check access in all programs this person is enrolled in, and the user might not have access to all of them. Let's open this can of worms in the future.)

...rkingLists/TeiWorkingLists/TrackedEntityBulkActions/Actions/CompleteAction/CompleteAction.js Outdated Show resolved Hide resolved
@eirikhaugstulen
Copy link
Contributor Author

Thanks, @simonadomnisoru! Should be implemented now 😊

simonadomnisoru
simonadomnisoru approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🥳

@eirikhaugstulen
Merge remote-tracking branch 'refs/remotes/origin/master' into eh/fea…
0314229 
…t/DHIS2-15187-working-list-bulk-action

# Conflicts:
#	i18n/en.pot
@eirikhaugstulen
docs: [DHIS2-15187][DHIS2-15190] Working list bulk actions (#3867)
09f985c 
* docs: add working list bulk actions docs

* chore: change title
@eirikhaugstulen eirikhaugstulen requested review from a team as code owners October 30, 2024 10:40
geethaalwan
geethaalwan approved these changes Nov 4, 2024
View reviewed changes
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,2.41.3,2.40.6,2.39.8 versions

@eirikhaugstulen eirikhaugstulen merged commit 5a12722 into master Nov 12, 2024
34 of 39 checks passed
@eirikhaugstulen eirikhaugstulen deleted the eh/feat/DHIS2-15187-working-list-bulk-action branch November 12, 2024 08:51
dhis2-bot added a commit that referenced this pull request Nov 12, 2024
@dhis2-bot
chore(release): cut 101.15.0 [skip release]
d98edab 
# [101.15.0](v101.14.9...v101.15.0) (2024-11-12)

### Features

* [DHIS2-15187][DHIS2-15190] Working list bulk actions ([#3773](#3773)) ([5a12722](5a12722))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geethaalwan geethaalwan geethaalwan approved these changes

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

Assignees
No one assigned
Labels
e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eirikhaugstulen @dhis2-bot @simonadomnisoru @geethaalwan