feat: [DHIS2-18328] Handle log entries for occurredAt, scheduledAt and geometry #3887
+161
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-3887.capture.netlify.dhis2.org |
henrikmv
added
e2e record
…/feat/DHIS2-18328_GeometryScheduledAtAndOccuredAtInChangelog
henrikmv
removed
the
e2e record
There was a problem hiding this comment.
Hi @henrikmv,
In addition to the comments in the code, I also noticed that occurredAt and scheduledAt are missing the time part. According to the Jira ticket, they should be displayed the same way as the DATETIME value type.
Can you have a look? Thanks!
src/core_modules/capture-core/components/Coordinates/PolygonCoordinates/PolygonCoordinates.js
Outdated
Show resolved
Hide resolved
src/core_modules/capture-core/components/Coordinates/MinimalCoordinates/MinimalCoordinates.js
Outdated
Show resolved
Hide resolved
...ure-core/components/WidgetEventEdit/EventChangelogWrapper/EventChangelogWrapper.component.js
Outdated
Show resolved
Hide resolved
src/core_modules/capture-core/components/Coordinates/PolygonCoordinates/PolygonCoordinates.js
Outdated
Show resolved
Hide resolved
|
@henrikmv, the code LGTM now 👏 ! Is it possible to add some cypress scenarios for the changelog geometry? The following program stage metadata is already set up in the Serra Leona DB and can be used:
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHIS2-18328
EventChangelogWrappercomponent now includes additional fields for geometry based on the feature type.ChangelogValueCellcomponent styles were adjusted for better display.useListDataValueshook was updated to handle the new property field.clientToListconverter was updated to use the new andPolygonCoordinatescomponent.serverToClientconverter was updated to handle coordinate and polygon data for Changelog.