Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DHIS2 15466] typing the date when editing enrollment and incident date #3905

Open
wants to merge 1 commit into
base: DHIS2-18310-enable-non-gregorian-calendars-in-views-and-lists
Choose a base branch
from
Open

feat: [DHIS2 15466] typing the date when editing enrollment and incident date #3905

wants to merge 1 commit into from

Conversation

alaa-yahia
Copy link
Member

@alaa-yahia alaa-yahia commented Dec 9, 2024 •
edited
Loading

Implement DHIS2 15466

In Enrolment Widget:

  • Display and pick non-Gregorian dates.
  • Follow system setting format for dates.
  • Display errors when date is invalid.
  • Refactor code to use DateField component instead of using CalendarInput directly.

@alaa-yahia alaa-yahia requested a review from a team as a code owner December 9, 2024 20:02
@alaa-yahia alaa-yahia changed the base branch from master to DHIS2-18310-enable-non-gregorian-calendars-in-views-and-lists December 10, 2024 10:30
simonadomnisoru
simonadomnisoru approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alaa-yahia @simonadomnisoru