Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DHIS2-18614] prevent runtime error when only one date range is selected #3906

Conversation

alaa-yahia
Copy link
Member

@alaa-yahia alaa-yahia commented Dec 11, 2024

Implements DHIS2-18614

When selecting only a from or to date in the date range filter, the application throws a runtime error, which this PR fixes

@alaa-yahia alaa-yahia requested a review from a team as a code owner December 11, 2024 22:32
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,2.41.3,2.40.7,2.39.9 versions

@alaa-yahia alaa-yahia merged commit 4699a84 into master Dec 13, 2024
39 of 42 checks passed
@alaa-yahia alaa-yahia deleted the fix-prevent-runtime-error-when-only-one-date-range-is-selected branch December 13, 2024 14:41
dhis2-bot added a commit that referenced this pull request Dec 13, 2024
## [101.19.3](v101.19.2...v101.19.3) (2024-12-13)

### Bug Fixes

* [DHIS2-18614] prevent runtime error when only one date range is selected ([#3906](#3906)) ([4699a84](4699a84))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.19.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants