Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [DHIS2-18876] replace deprecated parameters from 2.41 #3962

Merged
merged 8 commits into from
Feb 25, 2025
Merged

fix: [DHIS2-18876] replace deprecated parameters from 2.41 #3962

merged 8 commits into from
Feb 25, 2025

Conversation

simonadomnisoru
Copy link
Contributor

@simonadomnisoru simonadomnisoru commented Feb 10, 2025 •
edited by jira bot
Loading

DHIS2-18876

Tech summary

  • replace deprecated parameters in 2.41
  • remove hasAPISupportForFeature and server minor version logic and use featureAvailable instead

@simonadomnisoru simonadomnisoru marked this pull request as ready for review February 11, 2025 08:30
@simonadomnisoru simonadomnisoru requested a review from a team as a code owner February 11, 2025 08:30
henrikmv
henrikmv approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@henrikmv henrikmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done with the replacement of the parameters and feature support functions.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

🚀 Deployed on https://deploy-preview-3962.capture.netlify.dhis2.org

geethaalwan
geethaalwan approved these changes Feb 24, 2025
View reviewed changes
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,2.41.4 versions

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
17.2% Duplication on New Code

See analysis details on SonarQube Cloud

@simonadomnisoru simonadomnisoru merged commit 27a78b3 into master Feb 25, 2025
42 checks passed
@simonadomnisoru simonadomnisoru deleted the DHIS2-18876 branch February 25, 2025 09:23
dhis2-bot added a commit that referenced this pull request Feb 25, 2025
@dhis2-bot
chore(release): cut 101.28.1 [skip release]
179dec3 
## [101.28.1](v101.28.0...v101.28.1) (2025-02-25)

### Bug Fixes

* [DHIS2-18876] replace deprecated parameters from 2.41 ([#3962](#3962)) ([27a78b3](27a78b3))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geethaalwan geethaalwan geethaalwan approved these changes

@henrikmv henrikmv henrikmv approved these changes

Assignees
No one assigned
Labels
released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonadomnisoru @dhis2-bot @geethaalwan @henrikmv