fix: [DHIS2-18958] Add loading functionality to Search in all programs button #3965
Conversation
There was a problem hiding this comment.
Hi @henrikmv,
The Search all programs button loading functionality looks great 👏 . I just was wondering if we should add a loading spinner when changing pages too (just like we do when searching in a specific program)? This is not in the Jira ticket but it feels related and may also be an easy fix. Any thoughts?
Thanks!
Thanks Simona! That is a good suggestion and has now been implemented. |
|
|
🚀 Deployed on https://deploy-preview-3965.capture.netlify.dhis2.org |
henrikmv
deleted the
hv/fix/DHIS2-18958_MissingLoadingSpinnerForSearchAllProgramsButton
branch
## [101.27.1](v101.27.0...v101.27.1) (2025-02-17) ### Bug Fixes * [DHIS2-18958] Add loading functionality to Search in all programs button ([#3965](#3965)) ([6486942](6486942))
|
🎉 This PR is included in version 101.27.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
DHIS2-18958:
When the button is clicked, it enters a loading state. It will remain in this state until the Redux variable
otherResultsis defined. This ensures that the button stays in a loading state while the search is in progress and updates only when results are available.A loading spinner is also implemented when navigating between pages while searching across all programs.