fix: set basedir for plugin resolution #469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://dhis2.atlassian.net/browse/DHIS2-16776 and https://stylelint.io/user-guide/cli#--config-basedir
I've tried to replicate the existing approach as much as possible, mostly eslint. Usually you'd run stylelint from the root of the project and pass it a glob or list of relative filenames.
What we do is set the cwd to where cli-style is installed in node_modules, then we call the stylelint binary (by its absolute path) and pass it the files it should lint as absolute paths. This is not just confusing for humans but also for stylelint. So to help it find the plugins it needs we need to set
--config-basedir
to the cwd (cwd beingPACKAGE_ROOT
, notprocess.cwd()
)