Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: mention prettier in gettingStarted [LIBS-646] #471

Merged
merged 1 commit into from
Jul 23, 2024
Merged

chore: mention prettier in gettingStarted [LIBS-646] #471

merged 1 commit into from
Jul 23, 2024

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Jul 22, 2024

See https://dhis2.atlassian.net/browse/LIBS-646

  • Mentions prettier
  • cleans up the sample documentation for adding eslint react (where tool: eslint, template: react)

@tomzemp tomzemp requested review from Topener and a team July 22, 2024 14:17
Topener
Topener reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@Topener Topener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomzemp tomzemp merged commit b6982d2 into master Jul 23, 2024
7 checks passed
@tomzemp tomzemp deleted the LIBS-646/add-prettier-setup branch July 23, 2024 13:10
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.7.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaminic flaminic flaminic approved these changes

@Topener Topener Topener approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomzemp @dhis2-bot @Topener @flaminic