fix: ou group filter crashes in custom widgets [v39] #2692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2692--dhis2-dashboard.netlify.app |
8 failed tests on run #4094 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Viewing dashboards > I switch between dashboards |
Output
Screenshots
Video
|
|
view/view_errors.feature • 1 failed test • e2e
| Test | Artifacts | |
|---|---|---|
| Errors while in view mode > There are no dashboards |
Output
Screenshots
Video
|
|
view/responsive_dashboard.feature • 1 failed test • e2e
| Test | Artifacts | |
|---|---|---|
| Small screen dashboard > I view a dashboard |
Output
Screenshots
Video
|
|
edit/edit_dashboard.feature • 1 failed test • e2e
| Test | Artifacts | |
|---|---|---|
| Creating, editing and deleting dashboard > I create a new dashboard |
Output
Screenshots
Video
|
|
view/dashboard_filter.feature • 1 failed test • e2e
| Test | Artifacts | |
|---|---|---|
| Dashboard filter > I add a Period filter |
Output
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 8 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
edoardo
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2691
Fixes DHIS2-14544
If path exists, then parse it, otherwise use id (which will be the case for groups, levels and USER_ORGUNITS)