-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve support for right-to-left languages in Dashboard app #2985
Conversation
Bumps [express](https://github.com/expressjs/express) from 4.18.1 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.1...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
dd58c05
to
da03e77
Compare
da03e77
to
a5e27fc
Compare
a5e27fc
to
1083b47
Compare
….19.2 chore(deps): bump express from 4.18.1 to 4.19.2
🚀 Deployed on https://pr-2985.dashboard.netlify.dhis2.org |
@kabaros There is a lint error in ItemGrid.css. Could you look into it? |
@kabaros Maybe I'm doing something wrong here, but I can't get the app to run locally: |
I went ahead and changed it according to the recommendation. Please check that my change is correct. |
dashboards-app Run #4997
Run Properties:
|
Project |
dashboards-app
|
Branch Review |
DHIS2-16777/rtl-support
|
Run status |
Passed #4997
|
Run duration | 01m 45s |
Commit |
0c28a71b0d ℹ️: Merge 00c71016761b5c3b0e34336052c4363d278145bb into 85b3da89489ddf3c3ef86af1a439...
|
Committer | Mozafar |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
8
|
View all changes introduced in this branch ↗︎ |
Use this url for testing: |
All the bugs reported here are now fixed. |
# [100.3.0](v100.2.5...v100.3.0) (2024-09-26) ### Features * improve support for right-to-left languages in Dashboard app ([#2985](#2985)) ([9b3b585](9b3b585)), closes [ui#1448](https://github.com/ui/issues/1448) [app-platform#825](https://github.com/app-platform/issues/825) [cli-style#464](https://github.com/cli-style/issues/464)
🎉 This PR is included in version 100.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Implements DHIS2-16778
Key features
cli-style
to a version that supports checking logical properties (and automatically converting physical to logical properties)Description
This PR implements better support for right-to-left languages in the app, by leveraging the use of logical CSS properties that are independent of language direction, rather than physical properties (i.e.
*-start
instead of-left
and*-end
instead*-right
). Logical properties are widely supported now and they should become the default way for layout going-forward to ensure that we support RTL languages without extra development burden (which will be enforced byd2 style
).Although the change set is big. It's mostly done automatically using
d2 style apply css
which under the hood uses stylelint to enforce and apply the rules.The better support for RTL builds on top of previous work done in the platform, namely:
d2.config
that allows apps to declare they're ready to support RT. The platform changes also takes care of setting the correct direction and language for the header among other things: feat: add configurabledir
for language directions to app adapter [DHIS2-16480] app-platform#825Testing
Screenshots