Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update depencies (including ui/header-bar) [DHIS2-8651] #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Jan 27, 2023

Updated underlying dependencies, in part to update header bar for DHIS-8651

e.g. before
image

after
image

@tomzemp tomzemp requested a review from a team as a code owner January 27, 2023 15:04
@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-45--dhis2-data-exchange.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify January 27, 2023 15:06 Inactive
@KaiVandivier
Copy link

I think a more sustainable way of bumping the UI dependency for the headerbar is to bump the UI version in the app-platform/shell/package.json, then bump the @dhis2/cli-app-scripts version here, which will use the new App Adapter with the new Headerbar component 🙂

I'm also wary of actions like yarn upgrade that change dependencies without much history in package.json, since I've seen it create hard-to-debug situations before 😬 maybe it's a fine practice and I'm overreacting though -- I'm curious what others think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants