Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visualization menu icon size #2940

Merged
merged 4 commits into from
Mar 18, 2024
Merged

fix: visualization menu icon size #2940

merged 4 commits into from
Mar 18, 2024

Conversation

cooper-joe
Copy link
Member

This PR adjusts the visualization type icon in the visualization type selection menu. The previous icon was scaled too far down and appeared blurry.

Screenshots

Before:
image

image

image

After:
image

image

image

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Dec 18, 2023

@dhis2-bot dhis2-bot temporarily deployed to netlify December 18, 2023 13:53 Inactive
Copy link

cypress bot commented Dec 18, 2023

1 flaky test on run #2710 ↗︎

0 767 2 0 Flakiness 1

Details:

Merge 2f6de45 into 1d116ed...
Project: Data Visualizer App Commit: aa28ec216e ℹ️
Status: Passed Duration: 06:26 💡
Started: Mar 18, 2024 10:28 AM Ended: Mar 18, 2024 10:35 AM
Flakiness  cypress/integration/dimensions/data.cy.js • 1 flaky test • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Data dimension > displays Program indicators correctly Test Replay Screenshots Video

Review all test suite changes for PR #2940 ↗︎

@dhis2-bot dhis2-bot temporarily deployed to netlify January 4, 2024 14:12 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 1, 2024 13:10 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 16, 2024 09:21 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 7, 2024 07:27 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 7, 2024 09:51 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 18, 2024 10:22 Inactive
@edoardo edoardo merged commit bb05e17 into dev Mar 18, 2024
22 of 23 checks passed
@edoardo edoardo deleted the fix-viz-menu-icon branch March 18, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants