chore: upgrade @dhis2/analytics for scoped pivot table styles v39 #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3103--dhis2-data-visualizer.netlify.app |
Passing run #2893 ↗︎
Details:
Review all test suite changes for PR #3103 ↗︎ |
|||||||||||||||
HendrikThePendric
changed the title
HendrikThePendric
changed the title
edoardo
approved these changes
Jun 20, 2024
HendrikThePendric
deleted the
DHIS2-14028-update-analytics-for-pivot-tables-with-scoped-styles-v39
branch
HendrikThePendric
added a commit
that referenced
this pull request
Jun 20, 2024
* chore: upgrade analytics dependency to branch ci bundle * fix: upgrade analytics package to 24.10.11 * chore: update yarn.lock file
HendrikThePendric
added a commit
that referenced
this pull request
Jun 21, 2024
* Revert "chore: upgrade @dhis2/analytics for scoped pivot table styles v39 (#3103)" This reverts commit c6eab75. * fix: upgrade @dhis2/analytics for scoped pivot table styles v39 (#3103) * chore: upgrade analytics dependency to branch ci bundle * fix: upgrade analytics package to 24.10.11 * chore: update yarn.lock file
dhis2-bot
added a commit
that referenced
this pull request
Jun 21, 2024
|
🎉 This PR is included in version 39.2.37 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-14028
Description
The
PivotTablein@dhis2/analyticsno longer has global styles that bleed out of the component. It now uses scoped styles instead, which is much better in general. However, since plugins are in iframes from version 40 onwards, this fix is only required for this v39 branch.Once this is merged and a new version is released, dhis2/dashboard-app#3014 needs to be updated to use that new version for the data-visualizer-plugin dependency.