Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use saved visualization in interpretation modal (v39) #3122

Conversation

HendrikThePendric
Copy link
Contributor

@HendrikThePendric HendrikThePendric commented Jun 24, 2024

Implements DHIS2-15894

v39 backport of #3121


Key features

Use saved visualization in interpretation modal instead of current (dirty) visualization

@dhis2-bot
Copy link
Contributor

Copy link

cypress bot commented Jun 24, 2024

1 flaky test on run #2896 ↗︎

0 625 0 0 Flakiness 1

Details:

Merge c7f5d70 into d3fa8fb...
Project: Data Visualizer App Commit: 0e743744f8 ℹ️
Status: Passed Duration: 10:36 💡
Started: Jun 24, 2024 7:45 AM Ended: Jun 24, 2024 7:56 AM

Review all test suite changes for PR #3122 ↗︎

@HendrikThePendric HendrikThePendric changed the title fix: use saved visualization in interpretation modal fix: use saved visualization in interpretation modal (v39) Jun 24, 2024
@HendrikThePendric HendrikThePendric marked this pull request as ready for review June 24, 2024 08:43
@HendrikThePendric HendrikThePendric enabled auto-merge (squash) June 24, 2024 09:04
@HendrikThePendric HendrikThePendric merged commit 82907ee into 39.x Jun 24, 2024
16 checks passed
@HendrikThePendric HendrikThePendric deleted the DHIS2-15894-saved-visualization-in-interpretations-modal-v39 branch June 24, 2024 12:37
dhis2-bot added a commit that referenced this pull request Jun 24, 2024
## [39.2.38](v39.2.37...v39.2.38) (2024-06-24)

### Bug Fixes

* use saved visualization in interpretation modal [v39] ([#3122](#3122)) ([82907ee](82907ee))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 39.2.38 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants