Merge pull request #2066 from dhis2/androsdk-1782

fix: [ANDROSDK-1782] Support search by trackedEntity in TEI search
dhis2 · Nov 8, 2023 · 24c8d0d · 24c8d0d
2 parents b47f48b + 38433a3
commit 24c8d0d
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 2 deletions.
diff --git a/...ackedentity/search/TrackedEntityInstanceQueryCollectionRepositoryMockIntegrationShould.kt b/...ackedentity/search/TrackedEntityInstanceQueryCollectionRepositoryMockIntegrationShould.kt
@@ -126,6 +126,15 @@ class TrackedEntityInstanceQueryCollectionRepositoryMockIntegrationShould :
         assertThat(trackedEntityInstances.size).isEqualTo(1)
     }
 
+    @Test
+    fun find_by_uid() {
+        val trackedEntityInstances = d2.trackedEntityModule().trackedEntityInstanceQuery()
+            .byTrackedEntities().eq("nWrB0TfWlvh")
+            .blockingGet()
+
+        assertThat(trackedEntityInstances.size).isEqualTo(1)
+    }
+
     @Test
     fun exclude_uids() {
         val trackedEntityInstances = d2.trackedEntityModule().trackedEntityInstanceQuery()

diff --git a/...tapp/trackedentity/search/TrackedEntitySearchCollectionRepositoryMockIntegrationShould.kt b/...tapp/trackedentity/search/TrackedEntitySearchCollectionRepositoryMockIntegrationShould.kt
@@ -80,6 +80,16 @@ class TrackedEntitySearchCollectionRepositoryMockIntegrationShould :
         assertThat(trackedEntityInstances[1].header).isEqualTo("654321, ")
     }
 
+    @Test
+    fun should_return_header_in_object_repository() {
+        val trackedEntity = d2.trackedEntityModule().trackedEntitySearch()
+            .byProgram().eq("IpHINAT79UW")
+            .uid("nWrB0TfWlvh")
+            .blockingGet()
+
+        assertThat(trackedEntity?.header).isEqualTo("4081507, befryEfXge5")
+    }
+
     @Test
     fun should_return_ordered_attributes() {
         val trackedEntity = d2.trackedEntityModule().trackedEntitySearch()

diff --git a/.../dhis/android/core/trackedentity/search/TrackedEntityInstanceQueryCollectionRepository.kt b/.../dhis/android/core/trackedentity/search/TrackedEntityInstanceQueryCollectionRepository.kt
@@ -199,7 +199,7 @@ class TrackedEntityInstanceQueryCollectionRepository internal constructor(
     }
 
     override fun uid(uid: String?): ReadOnlyObjectRepository<TrackedEntityInstance> {
-        return objectRepository(
+        return byTrackedEntities().eq(uid).objectRepository(
             object : Transformer<List<TrackedEntityInstance>, TrackedEntityInstance?> {
                 override fun transform(o: List<TrackedEntityInstance>): TrackedEntityInstance? {
                     return o.find { uid == it.uid() }

diff --git a/...rg/hisp/dhis/android/core/trackedentity/search/TrackedEntitySearchCollectionRepository.kt b/...rg/hisp/dhis/android/core/trackedentity/search/TrackedEntitySearchCollectionRepository.kt
@@ -167,7 +167,7 @@ class TrackedEntitySearchCollectionRepository internal constructor(
     }
 
     override fun uid(uid: String?): ReadOnlyObjectRepository<TrackedEntitySearchItem> {
-        return objectRepository(
+        return byTrackedEntities().eq(uid).objectRepository(
             object : Transformer<List<TrackedEntitySearchItem>, TrackedEntitySearchItem?> {
                 override fun transform(o: List<TrackedEntitySearchItem>): TrackedEntitySearchItem? {
                     return o.find { uid == it.uid() }

diff --git a/...main/java/org/hisp/dhis/android/core/trackedentity/search/TrackedEntitySearchOperators.kt b/...main/java/org/hisp/dhis/android/core/trackedentity/search/TrackedEntitySearchOperators.kt
@@ -345,6 +345,17 @@ abstract class TrackedEntitySearchOperators<R : BaseRepository> internal constru
         }
     }
 
+    /**
+     * Filter by trackedEntity uid
+     *
+     * @return Repository connector
+     */
+    fun byTrackedEntities(): ListFilterConnector<R, String> {
+        return connectorFactory.listConnector { list: List<String> ->
+            scope.toBuilder().uids(list).build()
+        }
+    }
+
     /**
      * Whether to allow or not cached results for online queries. Its value is 'false' by default.
      *