Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert acl check on user group update #15443

Merged
merged 6 commits into from
Nov 6, 2023
Merged

fix: revert acl check on user group update #15443

merged 6 commits into from
Nov 6, 2023

Conversation

netroms
Copy link
Contributor

@netroms netroms commented Oct 19, 2023

Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #15443 (d09760f) into 2.39 (886690f) will increase coverage by 6.19%.
Report is 100 commits behind head on 2.39.
The diff coverage is 66.76%.

@@             Coverage Diff              @@
##               2.39   #15443      +/-   ##
============================================
+ Coverage     58.58%   64.77%   +6.19%     
- Complexity    25817    28684    +2867     
============================================
  Files          3207     3212       +5     
  Lines        121397   121823     +426     
  Branches      14158    14217      +59     
============================================
+ Hits          71118    78914    +7796     
+ Misses        44340    36423    -7917     
- Partials       5939     6486     +547     
Flag Coverage Δ
integration 48.57% <29.87%> (-0.02%) ⬇️
integration-h2 34.00% <24.39%> (?)
unit 29.56% <40.24%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...main/java/org/hisp/dhis/appmanager/AppManager.java 100.00% <ø> (ø)
...src/main/java/org/hisp/dhis/category/Category.java 65.21% <100.00%> (ø)
...ava/org/hisp/dhis/common/BaseAnalyticalObject.java 70.95% <100.00%> (+5.81%) ⬆️
...a/org/hisp/dhis/common/BaseIdentifiableObject.java 80.20% <100.00%> (+1.37%) ⬆️
...s-api/src/main/java/org/hisp/dhis/common/Grid.java 0.00% <ø> (ø)
.../src/main/java/org/hisp/dhis/common/QueryItem.java 68.66% <100.00%> (ø)
...isp/dhis/dataapproval/DataApprovalPermissions.java 91.66% <ø> (+22.43%) ⬆️
...rc/main/java/org/hisp/dhis/feedback/ErrorCode.java 100.00% <100.00%> (ø)
...src/main/java/org/hisp/dhis/period/PeriodType.java 85.45% <100.00%> (+1.91%) ⬆️
...rg/hisp/dhis/resourcetable/ResourceTableStore.java 100.00% <ø> (+100.00%) ⬆️
... and 103 more

... and 549 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e807ab...d09760f. Read the comment docs.

@david-mackessy
Copy link
Contributor

if this is a back port, can you link the PR it's a back port from (like we usually do) so we can see why this back port is being reverted (ideally the original PR gives the reason for reverting).

@david-mackessy
Copy link
Contributor

i can see the original PR in the commits - ignore my previous comment

@netroms netroms merged commit 9c8f35f into 2.39 Nov 6, 2023
12 checks passed
@netroms netroms deleted the DHIS2-15787_2.39 branch November 6, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants