Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: im-play/dev [2.39] #15510

Merged
merged 3 commits into from
Oct 27, 2023
Merged

ci: im-play/dev [2.39] #15510

merged 3 commits into from
Oct 27, 2023

Conversation

tonsV2
Copy link
Contributor

@tonsV2 tonsV2 commented Oct 27, 2023

tonsV2 added 3 commits October 26, 2023 22:00
@tonsV2
im-play/dev (#15481)
9031267 
* chore: deploy all supported dev branches [skip ci]

* chore: use database slug rather than retrieving id [skip ci]

* chore: clean up [skip ci]

* chore: fix indent [skip ci]

* chore: set image tag based on the branch [skip ci]

* chore: test with 2.40

* chore: dns_rfc1035 can't start with numeric char

* chore: misc. clean up

(cherry picked from commit 90f5d0f)
Signed-off-by: TonsV2 <[email protected]>
@tonsV2
chore: s/replaceAll/replace/
be997d0 
Signed-off-by: TonsV2 <[email protected]>
@tonsV2
ci: fix scope
81dc146 
Signed-off-by: TonsV2 <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #15510 (81dc146) into 2.39 (886690f) will increase coverage by 6.17%.
Report is 93 commits behind head on 2.39.
The diff coverage is 66.80%.

@@             Coverage Diff              @@
##               2.39   #15510      +/-   ##
============================================
+ Coverage     58.58%   64.75%   +6.17%     
- Complexity    25817    28674    +2857     
============================================
  Files          3207     3212       +5     
  Lines        121397   121824     +427     
  Branches      14158    14216      +58     
============================================
+ Hits          71118    78886    +7768     
+ Misses        44340    36454    -7886     
- Partials       5939     6484     +545
Flag Coverage Δ
integration 48.56% <29.84%> (-0.04%) ⬇️
integration-h2 33.98% <24.08%> (?)
unit 29.56% <41.25%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...main/java/org/hisp/dhis/appmanager/AppManager.java 100.00% <ø> (ø)
...src/main/java/org/hisp/dhis/category/Category.java 65.21% <100.00%> (ø)
...ava/org/hisp/dhis/common/BaseAnalyticalObject.java 70.95% <100.00%> (+5.81%) ⬆️
...a/org/hisp/dhis/common/BaseIdentifiableObject.java 80.20% <100.00%> (+1.37%) ⬆️
...s-api/src/main/java/org/hisp/dhis/common/Grid.java 0.00% <ø> (ø)
.../src/main/java/org/hisp/dhis/common/QueryItem.java 68.66% <100.00%> (ø)
...isp/dhis/dataapproval/DataApprovalPermissions.java 91.66% <ø> (+22.43%) ⬆️
...rc/main/java/org/hisp/dhis/feedback/ErrorCode.java 100.00% <100.00%> (ø)
...src/main/java/org/hisp/dhis/period/PeriodType.java 85.45% <100.00%> (+1.91%) ⬆️
...rg/hisp/dhis/resourcetable/ResourceTableStore.java 100.00% <ø> (+100.00%) ⬆️
... and 97 more

... and 550 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b0d56...81dc146. Read the comment docs.

@tonsV2 tonsV2 enabled auto-merge (squash) October 27, 2023 05:02
@tonsV2 tonsV2 merged commit 2566923 into 2.39 Oct 27, 2023
12 checks passed
@tonsV2 tonsV2 deleted the feature/im-play_2.39 branch October 27, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radnov radnov radnov approved these changes

@Philip-Larsen-Donnelly Philip-Larsen-Donnelly Awaiting requested review from Philip-Larsen-Donnelly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonsV2 @radnov