Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add check for deploy label [skip ci] #15513

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Conversation

radnov
Copy link
Contributor

@radnov radnov commented Oct 27, 2023

This PR also includes the following improvements/fixes:

  • trigger the Destroy workflow when the deploy label is removed
  • use a fork of the wait-on-check action that checks only the latest (current) run of a check, instead of all re-runs
  • use IM instance status endpoint for making sure instance is running
  • delete instance URL comment when destroying

@radnov radnov added the deploy Deploy DHIS2 instance with IM. label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #15513 (8ed86a2) into master (5b62825) will increase coverage by 0.07%.
Report is 10 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #15513      +/-   ##
============================================
+ Coverage     66.15%   66.22%   +0.07%     
- Complexity    31176    31236      +60     
============================================
  Files          3485     3485              
  Lines        129745   129747       +2     
  Branches      15134    15141       +7     
============================================
+ Hits          85828    85922      +94     
+ Misses        36830    36742      -88     
+ Partials       7087     7083       -4     
Flag Coverage Δ
integration 49.77% <ø> (+0.07%) ⬆️
integration-h2 32.39% <ø> (-0.03%) ⬇️
unit 30.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b62825...8ed86a2. Read the comment docs.

Using the HEAD branch ref when checking for the api-tests workflow
can lead to checking the status of multiple runs and failing,
because we only want successfull ones.
@radnov radnov force-pushed the fix-destroy-workflow branch from 2407129 to fa32ea7 Compare October 27, 2023 11:56
@radnov radnov marked this pull request as draft October 27, 2023 12:28
@radnov radnov force-pushed the fix-destroy-workflow branch 4 times, most recently from 5060fe3 to e456057 Compare October 27, 2023 17:35
@radnov radnov added the test label Oct 27, 2023
@radnov radnov force-pushed the fix-destroy-workflow branch from e456057 to 6f8f91a Compare October 27, 2023 20:26
@radnov radnov added deploy Deploy DHIS2 instance with IM. and removed deploy Deploy DHIS2 instance with IM. test labels Oct 27, 2023
@radnov radnov added test deploy Deploy DHIS2 instance with IM. and removed deploy Deploy DHIS2 instance with IM. test labels Oct 30, 2023
@radnov radnov force-pushed the fix-destroy-workflow branch from edf53d8 to deebaa3 Compare October 30, 2023 07:15
@radnov radnov added deploy Deploy DHIS2 instance with IM. and removed deploy Deploy DHIS2 instance with IM. labels Oct 30, 2023
@radnov radnov added Work In Progress deploy Deploy DHIS2 instance with IM. and removed Work In Progress labels Oct 30, 2023
@radnov radnov force-pushed the fix-destroy-workflow branch from deebaa3 to 8ed86a2 Compare October 30, 2023 11:01
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@radnov radnov added deploy Deploy DHIS2 instance with IM. Work In Progress and removed deploy Deploy DHIS2 instance with IM. labels Oct 30, 2023
@github-actions
Copy link

Instance deployed to https://dev.im.dhis2.org/pr-15513

@radnov radnov merged commit a2ac7dc into master Nov 2, 2023
29 of 32 checks passed
@radnov radnov deleted the fix-destroy-workflow branch November 2, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploy DHIS2 instance with IM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants