Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for 'created' [DHIS2-16058] #15520

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

gnespolino
Copy link
Contributor

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gnespolino gnespolino added the run-api-analytics-tests Enables analytics e2e tests label Oct 27, 2023
@gnespolino gnespolino enabled auto-merge (squash) October 27, 2023 15:03
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #15520 (fc36f42) into master (e1cdd70) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #15520   +/-   ##
=========================================
  Coverage     66.22%   66.22%           
+ Complexity    31233    31232    -1     
=========================================
  Files          3485     3485           
  Lines        129753   129754    +1     
  Branches      15136    15136           
=========================================
+ Hits          85933    85936    +3     
+ Misses        36738    36737    -1     
+ Partials       7082     7081    -1     
Flag Coverage Δ
integration 49.76% <0.00%> (-0.01%) ⬇️
integration-h2 32.41% <100.00%> (+0.02%) ⬆️
unit 30.35% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...hisp/dhis/analytics/common/CommonQueryRequest.java 100.00% <ø> (ø)
...java/org/hisp/dhis/common/AnalyticsDateFilter.java 92.30% <100.00%> (+8.97%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1cdd70...fc36f42. Read the comment docs.

@@ -187,6 +187,8 @@

private String lastUpdated;

private String created;

Check warning

Code scanning / CodeQL

Reference equality test on strings Warning

String values compared with == .
@gnespolino gnespolino merged commit 1313522 into master Oct 27, 2023
20 of 22 checks passed
@gnespolino gnespolino deleted the DHIS2-16058_supports_created branch October 27, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-api-analytics-tests Enables analytics e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants