-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Make async tracker importer use scheduler #15597
Conversation
8385298
to
a3df880
Compare
a3df880
to
bb58ec4
Compare
Codecov Report
@@ Coverage Diff @@
## master #15597 +/- ##
============================================
- Coverage 66.20% 66.17% -0.04%
+ Complexity 31264 31231 -33
============================================
Files 3487 3482 -5
Lines 129902 129815 -87
Branches 15170 15170
============================================
- Hits 86007 85901 -106
- Misses 36813 36837 +24
+ Partials 7082 7077 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…tracker_scheduler
...s/dhis-service-tracker/src/main/java/org/hisp/dhis/tracker/imports/TrackerImportService.java
Outdated
Show resolved
Hide resolved
Should there be an actual TrackerJob of some sort that implements the |
Exactly and this is done in |
Ah thanks Enrico :) I just did a simple search for 'implements Job 'in the PR but that class code wasn't expanded because of the size of the diff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job and it's covered with e2e tests. Great.
...service-tracker/src/main/java/org/hisp/dhis/tracker/imports/DefaultTrackerImportService.java
Outdated
Show resolved
Hide resolved
SonarCloud Quality Gate failed. 0 Bugs 0.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
This reverts commit 5cd719c.
Created
TrackerJobImport
for async calls of Tracker Importer.TrackerImportController
endpoints are converting the incoming request to aBody
object that adds some logic to be able to process the import. In particular tracker importer allows the client to send entities to be created without a UID and theBodyConverter
creates all missing UIDs in the payload.So
TrackerObjects
is the object that is serialized/deserialized and saved as a resource to be used by theScheduler
The big amount of changed files is caused by the change of some key signatures in the importer and this was necessary because in the previous implementation there was no good distinction between data and parameters.
Other changes:
ImportReport
, they are going to be present inJobProgress