Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove org unit in user scope from flaky test [DHIS2-16130] #15619

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

muilpp
Copy link
Contributor

@muilpp muilpp commented Nov 7, 2023

Removes the org unit passed in the test which is part of the user scope, to make test consistently pass with the expected result.
Ticket: https://dhis2.atlassian.net/browse/DHIS2-16130

@muilpp muilpp marked this pull request as ready for review November 7, 2023 19:08
@muilpp muilpp enabled auto-merge (squash) November 7, 2023 19:08
Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #15619 (67753e4) into master (b6648ef) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #15619      +/-   ##
============================================
- Coverage     66.24%   66.24%   -0.01%     
+ Complexity    31262    31261       -1     
============================================
  Files          3485     3485              
  Lines        129788   129788              
  Branches      15145    15145              
============================================
- Hits          85973    85972       -1     
  Misses        36731    36731              
- Partials       7084     7085       +1     
Flag Coverage Δ
integration 49.80% <ø> (-0.01%) ⬇️
integration-h2 32.42% <ø> (ø)
unit 30.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6648ef...67753e4. Read the comment docs.

@muilpp muilpp requested review from jbee and a team November 7, 2023 19:27
@muilpp muilpp merged commit 46d6ca1 into master Nov 8, 2023
18 checks passed
@muilpp muilpp deleted the DHIS2-16130 branch November 8, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants