feat: query API for job configurations with errors [DHIS2-15276] #15636
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #15636 +/- ##
=============================================
+ Coverage 49.39% 66.27% +16.88%
- Complexity 23283 31327 +8044
=============================================
Files 3483 3484 +1
Lines 129911 129986 +75
Branches 15182 15192 +10
=============================================
+ Hits 64166 86154 +21988
+ Misses 59684 36744 -22940
- Partials 6061 7088 +1027
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1222 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...dhis-service-core/src/main/java/org/hisp/dhis/scheduling/DefaultJobConfigurationService.java
Fixed
Show fixed
Hide fixed
| private UID user; | ||
|
|
||
| /** The earliest date the job ran that should be included */ | ||
| @CheckForNull private Date from; |
There was a problem hiding this comment.
Can we use LocalDate or LocalDateTime for new models seeing as we want to move to use these eventually? Or is there something restricting us from doing this?
There was a problem hiding this comment.
I think I should try at least, just did this out of a (bad) habit
There was a problem hiding this comment.
We don't have setup a flexible parsing for LocalDate in the same way we have for Date so for now I keep it Date. At some point we should make an attempt to switch dates in APIs over while supporting the parsing flexibility.
You got me :) Have to add some |
|
Kudos, SonarCloud Quality Gate passed! |
Summary
Adds an API endpoints to search and view error recordings attached to a
JobConfiguration.New APIs
/api/jobConfigurations/progress/errors: only the errors of theprogressJSON object flattened to an array of objects/api/jobConfigurations/{uid}/errors: errors of a specific job configuration as job run errors/api/jobConfigurations/errors: search API to list jobs with errors that give job run error entriesA entry of a job run errors has this structure:
[ { "id":"hg6LR5ls42g", "type":"METADATA_IMPORT", "user":"M5zQapPyTZI", "errors":[ { "id":"KfdsGBcoiCa", "args":[ "[brokenHdoxL] (CategoryOption)", "Births attended by [KfdsGBcoiCa] (Category)", "categoryOption" ], "code":"E5002", "type":"Category", "message":"Invalid reference [brokenHdoxL] (CategoryOption) on object Births attended by [KfdsGBcoiCa] (Category) for association `categoryOption`" }, { "id":"SvzFH1XEfJr", "args":[ "[brokenXoUN4] (CategoryOption)", "Labour complications [SvzFH1XEfJr] (Category)", "categoryOption" ], "code":"E5002", "type":"Category", "message":"Invalid reference [brokenXoUN4] (CategoryOption) on object Labour complications [SvzFH1XEfJr] (Category) for association `categoryOption`" } ], "created":"2023-11-14T11:05:59.374", "executed":"2023-11-14T11:06:13.815453", "filesize":11069, "filetype":"application/json", "finished":"2023-11-14T11:06:14.52768" } ]Manual Testing
/api/jobConfigurations/gist?filter=jobType:eq:METADATA_IMPORT&order=created:desc/api/jobConfigurations/errors/api/jobConfigurations/hg6LR5ls42g/errors(replace UID in path)http://localhost:8080/api/jobConfigurations/hg6LR5ls42g/progress/errors(replace UID in path)