-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Rename executiondate to occurreddate in DB [TECH-1615] #15648
Conversation
...-analytics/src/main/java/org/hisp/dhis/analytics/common/params/dimension/DimensionParam.java
Outdated
Show resolved
Hide resolved
…hisp/dhis/analytics/common/params/dimension/DimensionParam.java
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #15648 +/- ##
============================================
- Coverage 66.21% 66.21% -0.01%
+ Complexity 31267 31265 -2
============================================
Files 3487 3487
Lines 129904 129904
Branches 15170 15170
============================================
- Hits 86013 86010 -3
- Misses 36812 36813 +1
- Partials 7079 7081 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, api-e2e runs fine, so it should be good to go
Following on #15642
This PR aims to replace all occurrences of executionDate in the DB and repository layer to occurredDate.
The general rule that we are using is that date fields are suffixed with At in the API and then suffixed with Date in the service and the DB layer.