-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Rename endDate to completedDate in service layer [TECH-1665] #15652
Conversation
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #15652 +/- ##
=========================================
Coverage 66.21% 66.21%
Complexity 31267 31267
=========================================
Files 3487 3487
Lines 129904 129904
Branches 15170 15170
=========================================
+ Hits 86013 86014 +1
+ Misses 36812 36811 -1
Partials 7079 7079
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
just out of curiosity, is there a plan to name all these fields the same regardless of the layer they live in? |
@@ -32,7 +32,7 @@ | |||
|
|||
<property name="enrollmentDate" column="enrollmentdate" not-null="true"/> | |||
|
|||
<property name="endDate" column="enddate"/> | |||
<property name="completedDate" column="enddate"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enrollmentDate is mapped to enrollmentdate column. Can we do the same for completedDate?
completedAt
field inEnrollment
was internally translated toendDate
.This PR aims to replace all occurrences of
endDate
in the service layer tocompletedDate
.The general rule that we are using is that date fields are suffixed with
At
in the API and then suffixed withDate
in the service and the DB layer.Next PRs
occurredAt
in service layercompletedAt
in DB layeroccurredAt
in DB layer