Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cannot retrieve IDs for Potential Duplicate Records [DHIS2-16063] #15660

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

lucaCambi77
Copy link
Contributor

https://dhis2.atlassian.net/browse/DHIS2-16063

  • add uid to GET /potentialDuplicates response
  • add MVC test

Copy link

sonarcloud bot commented Nov 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lucaCambi77 lucaCambi77 requested a review from a team November 13, 2023 09:42
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #15660 (0eb027d) into master (21d1572) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #15660   +/-   ##
=========================================
  Coverage     66.21%   66.22%           
  Complexity    31267    31267           
=========================================
  Files          3487     3487           
  Lines        129904   129904           
  Branches      15170    15170           
=========================================
+ Hits          86013    86023   +10     
+ Misses        36812    36800   -12     
- Partials       7079     7081    +2     
Flag Coverage Δ
integration 49.78% <ø> (+<0.01%) ⬆️
integration-h2 32.42% <ø> (+0.02%) ⬆️
unit 30.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...troller/deduplication/DeduplicationController.java 83.78% <ø> (+16.21%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d1572...0eb027d. Read the comment docs.

@lucaCambi77 lucaCambi77 merged commit 79902c4 into master Nov 15, 2023
18 checks passed
@lucaCambi77 lucaCambi77 deleted the DHIS2_16063 branch November 15, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants