fix: Remove unnecessary calls to the DB during DataValueSet import [D…

[david-mackessy]

…HIS2-16159]
backport of #15688

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

[codecov]

Codecov Report

Merging #15698 (cddc7d3) into 2.39 (886690f) will increase coverage by 6.18%.
Report is 116 commits behind head on 2.39.
The diff coverage is 66.62%.

Additional details and impacted files

@@             Coverage Diff              @@
##               2.39   #15698      +/-   ##
============================================
+ Coverage     58.58%   64.77%   +6.18%     
- Complexity    25817    28692    +2875     
============================================
  Files          3207     3212       +5     
  Lines        121397   121820     +423     
  Branches      14158    14221      +63     
============================================
+ Hits          71118    78905    +7787     
+ Misses        44340    36427    -7913     
- Partials       5939     6488     +549     

Flag	Coverage Δ
integration	48.57% <37.85%> (-0.02%)	⬇️
integration-h2	33.97% <18.41%> (?)
unit	29.54% <43.95%> (+0.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...main/java/org/hisp/dhis/appmanager/AppManager.java	100.00% <ø> (ø)
...src/main/java/org/hisp/dhis/category/Category.java	65.21% <100.00%> (ø)
...ava/org/hisp/dhis/common/BaseAnalyticalObject.java	70.95% <100.00%> (+5.81%)	⬆️
...a/org/hisp/dhis/common/BaseIdentifiableObject.java	80.20% <100.00%> (+1.37%)	⬆️
...s-api/src/main/java/org/hisp/dhis/common/Grid.java	0.00% <ø> (ø)
.../src/main/java/org/hisp/dhis/common/QueryItem.java	68.66% <100.00%> (ø)
...isp/dhis/dataapproval/DataApprovalPermissions.java	91.66% <ø> (+22.43%)	⬆️
...rc/main/java/org/hisp/dhis/feedback/ErrorCode.java	100.00% <100.00%> (ø)
...src/main/java/org/hisp/dhis/period/PeriodType.java	85.45% <100.00%> (+1.91%)	⬆️
...rg/hisp/dhis/resourcetable/ResourceTableStore.java	100.00% <ø> (+100.00%)	⬆️
... and 113 more

... and 543 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b77ac0...cddc7d3. Read the comment docs.